This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run-all-tests tidb=release-3.0 |
csuzhangxc
reviewed
Dec 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
Co-Authored-By: Xuecheng Zhang <[email protected]>
Co-Authored-By: Xuecheng Zhang <[email protected]>
/run-all-tests tidb=release-3.0 |
Codecov Report
@@ Coverage Diff @@
## master #425 +/- ##
===========================================
Coverage ? 57.4675%
===========================================
Files ? 165
Lines ? 16893
Branches ? 0
===========================================
Hits ? 9708
Misses ? 6231
Partials ? 954 |
csuzhangxc
reviewed
Dec 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
csuzhangxc
added
priority/normal
Minor change, requires approval from ≥1 primary reviewer
needs-cherry-pick-release-1.0
This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0
needs-update-docs
Should update docs after this PR is merged. Remove this label once the docs are updated
status/LGT1
One reviewer already commented LGTM
type/CHANGELOG
This PR is udpating the CHANGELOG
labels
Dec 13, 2019
@WangXiangUSTC PTAL |
/run-all-tests tidb=release-3.0 |
WangXiangUSTC
approved these changes
Dec 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
WangXiangUSTC
added
status/LGT2
Two reviewers already commented LGTM, ready for merge
and removed
status/LGT1
One reviewer already commented LGTM
labels
Dec 13, 2019
cherry pick to release-1.0 in PR #428 |
sre-bot
added
already-cherry-pick-1.0
The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked
and removed
needs-cherry-pick-release-1.0
This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0
labels
Dec 13, 2019
csuzhangxc
pushed a commit
that referenced
this pull request
Dec 13, 2019
glorv
pushed a commit
to glorv/dm
that referenced
this pull request
Dec 25, 2019
* bump to v1.0.3 * Update CHANGELOG.md Co-Authored-By: Xuecheng Zhang <[email protected]> * Update CHANGELOG.md Co-Authored-By: Xuecheng Zhang <[email protected]> * address comments * update the release notes * update pingcap#353
csuzhangxc
added
already-update-docs
The docs related to this PR already updated. Add this label once the docs are updated
and removed
needs-update-docs
Should update docs after this PR is merged. Remove this label once the docs are updated
labels
Mar 13, 2020
lichunzhu
pushed a commit
to lichunzhu/dm
that referenced
this pull request
Apr 6, 2020
* bump to v1.0.3 * Update CHANGELOG.md Co-Authored-By: Xuecheng Zhang <[email protected]> * Update CHANGELOG.md Co-Authored-By: Xuecheng Zhang <[email protected]> * address comments * update the release notes * update pingcap#353
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
already-cherry-pick-1.0
The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked
already-update-docs
The docs related to this PR already updated. Add this label once the docs are updated
priority/normal
Minor change, requires approval from ≥1 primary reviewer
status/LGT2
Two reviewers already commented LGTM, ready for merge
type/CHANGELOG
This PR is udpating the CHANGELOG
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Prepare for v1.0.3 release
What is changed and how it works?
Add v1.0.3 release notes in Changelog
Check List
Tests
Related changes