Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

Update DM Portal #417

Merged
merged 7 commits into from
Dec 13, 2019
Merged

Update DM Portal #417

merged 7 commits into from
Dec 13, 2019

Conversation

baurine
Copy link
Contributor

@baurine baurine commented Dec 10, 2019

What problem does this PR solve?

#410

What is changed and how it works?

  • Remove the editing task.yml feature
  • Validate the task name, can't contain invalid characters
  • Add option to support sync with the upstream newly added tables and schemas
  • Differ the undo and reset actions more clearly

dm-portal-remove-edit


dm-portal-validate-task-name


dm-portal-auto-sync


dm-portal-undo

dm-portal-reset

@baurine baurine changed the title [WIP] Update DM Portal Update DM Portal Dec 11, 2019
@ericsyh
Copy link
Contributor

ericsyh commented Dec 11, 2019

/run-all-tests tidb=release-3.0

@csuzhangxc
Copy link
Member

/run-all-tests tidb=release-3.0

@codecov
Copy link

codecov bot commented Dec 11, 2019

Codecov Report

Merging #417 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master       #417   +/-   ##
===========================================
  Coverage   57.4735%   57.4735%           
===========================================
  Files           165        165           
  Lines         16893      16893           
===========================================
  Hits           9709       9709           
  Misses         6230       6230           
  Partials        954        954

@baurine baurine changed the title Update DM Portal [WIP] Update DM Portal Dec 12, 2019
@baurine
Copy link
Contributor Author

baurine commented Dec 12, 2019

/run-all-tests tidb=release-3.0

@baurine baurine changed the title [WIP] Update DM Portal Update DM Portal Dec 13, 2019
@baurine
Copy link
Contributor Author

baurine commented Dec 13, 2019

@ericsyh @WangXiangUSTC please help review again, thanks!

Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ericsyh ericsyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericsyh
Copy link
Contributor

ericsyh commented Dec 13, 2019

/run-all-tests tidb=release-3.0

1 similar comment
@baurine
Copy link
Contributor Author

baurine commented Dec 13, 2019

/run-all-tests tidb=release-3.0

@baurine baurine merged commit 41e9ecc into master Dec 13, 2019
@baurine baurine deleted the dm-portal branch December 13, 2019 13:15
glorv pushed a commit to glorv/dm that referenced this pull request Dec 25, 2019
* portal: rename dm-fe folder to frontend

* portal: udpate frontend README

* portal: add option to control whether auto sync with upstream newly added schemas or tables

* portal: validate the task name

* portal: differ the undo and reset action more clearly
baurine added a commit that referenced this pull request Feb 14, 2020
* portal: rename dm-fe folder to frontend

* portal: udpate frontend README

* portal: add option to control whether auto sync with upstream newly added schemas or tables

* portal: validate the task name

* portal: differ the undo and reset action more clearly
lichunzhu pushed a commit to lichunzhu/dm that referenced this pull request Apr 6, 2020
* portal: rename dm-fe folder to frontend

* portal: udpate frontend README

* portal: add option to control whether auto sync with upstream newly added schemas or tables

* portal: validate the task name

* portal: differ the undo and reset action more clearly
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants