Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

Fix the missing var dm_worker_instances for rolling_update_monitor (#407) #408

Merged
merged 1 commit into from
Dec 6, 2019
Merged

Fix the missing var dm_worker_instances for rolling_update_monitor (#407) #408

merged 1 commit into from
Dec 6, 2019

Conversation

sre-bot
Copy link

@sre-bot sre-bot commented Dec 6, 2019

cherry-pick #407 to release-1.0

What problem does this PR solve?

Fix the missing var "dm_worker_instances " for rolling_update_monitor

What is changed and how it works?

Add the var " dm_worker_instances " with the same logical as start.yml

@sre-bot sre-bot mentioned this pull request Dec 6, 2019
Merged
@sre-bot sre-bot added priority/normal Minor change, requires approval from ≥1 primary reviewer needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport) labels Dec 6, 2019
@amyangfei
Copy link
Contributor

/run-all-tests tidb=release-3.0

csuzhangxc
csuzhangxc reviewed Dec 6, 2019
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added the status/LGT1 One reviewer already commented LGTM label Dec 6, 2019
@codecov
Copy link

codecov bot commented Dec 6, 2019

Codecov Report

Merging #408 into release-1.0 will increase coverage by 0.077%.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##           release-1.0       #408       +/-   ##
==================================================
+ Coverage       57.179%   57.2561%   +0.077%     
==================================================
  Files              159        159               
  Lines            16172      16145       -27     
==================================================
- Hits              9247       9244        -3     
+ Misses            6019       5995       -24     
  Partials           906        906

amyangfei
amyangfei approved these changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei amyangfei added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Dec 6, 2019
@amyangfei amyangfei merged commit ab7be8b into pingcap:release-1.0 Dec 6, 2019
@csuzhangxc csuzhangxc added already-update-release-note The release note is updated. Add this label once the release note is updated and removed needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Mar 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@amyangfei amyangfei amyangfei approved these changes

Assignees
No one assigned
Labels
already-update-release-note The release note is updated. Add this label once the release note is updated priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sre-bot @amyangfei @csuzhangxc @SE-Bin