This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
*: fix context usage for SQL operation (#377) #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csuzhangxc
added
the
status/DNM
|
/run-all-tests tidb=release-3.0 |
Codecov Report
@@ Coverage Diff @@
## release-1.0 #400 +/- ##
=============================================
Coverage 57.179% 57.179%
=============================================
Files 159 159
Lines 16172 16172
=============================================
Hits 9247 9247
Misses 6017 6017
Partials 908 908 |
|
/run-all-tests tidb=release-3.0 |
|
/run-all-tests tidb=release-3.0 |
|
@WangXiangUSTC @GregoryIan PTAL |
|
LGTM |
|
/run-all-tests tidb=release-3.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry pick #377 manually before merged for testing.
What problem does this PR solve?
when retrying SQL operation to downstream,
stop-task/pause-taskmay not take effect because of the misuse of context.What is changed and how it works?
fix context usage for SQL operation to downstream, including:
NOTE:
retry_cancelintegration testing has much wait time, and I'll split it run separately in CI after received 2 LGTM.Check List
Tests
Side effects
Related changes