Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

*: use IsRetryableError in tidb-tools #390

Merged
merged 2 commits into from
Dec 2, 2019
Merged

*: use IsRetryableError in tidb-tools #390

merged 2 commits into from
Dec 2, 2019

Conversation

csuzhangxc
Copy link
Member

What problem does this PR solve?

replace IsRetryableError with the one in tidb-tools repo

What is changed and how it works?

  • update tidb-tools mod
  • replace IsRetryableError usage

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@csuzhangxc csuzhangxc added priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Dec 2, 2019
@csuzhangxc
Copy link
Member Author

/run-all-tests tidb=release-3.0

@csuzhangxc csuzhangxc added this to the v1.0.3 milestone Dec 2, 2019
@csuzhangxc
Copy link
Member Author

/run-all-tests tidb=release-3.0

1 similar comment
@csuzhangxc
Copy link
Member Author

/run-all-tests tidb=release-3.0

@codecov
Copy link

codecov bot commented Dec 2, 2019

Codecov Report

Merging #390 into master will decrease coverage by 0.0178%.
The diff coverage is 0%.

@@               Coverage Diff                @@
##             master       #390        +/-   ##
================================================
- Coverage   57.6602%   57.6424%   -0.0179%     
================================================
  Files           163        163                
  Lines         16455      16441        -14     
================================================
- Hits           9488       9477        -11     
+ Misses         6044       6040         -4     
- Partials        923        924         +1

@csuzhangxc
Copy link
Member Author

@WangXiangUSTC @amyangfei PTAL

@WangXiangUSTC
Copy link
Contributor

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Dec 2, 2019
amyangfei
amyangfei approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei amyangfei added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Dec 2, 2019
@csuzhangxc csuzhangxc merged commit 3d31d97 into pingcap:master Dec 2, 2019
@csuzhangxc csuzhangxc deleted the retryable-error branch December 2, 2019 06:19
@sre-bot sre-bot mentioned this pull request Dec 2, 2019
Merged
@sre-bot
Copy link

sre-bot commented Dec 2, 2019

cherry pick to release-1.0 in PR #391

@sre-bot sre-bot added already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 labels Dec 2, 2019
csuzhangxc pushed a commit that referenced this pull request Dec 3, 2019
@sre-bot @csuzhangxc
*: use IsRetryableError in tidb-tools (#390) (#391)
9f86c95
@ericsyh ericsyh removed this from the v1.0.3 milestone Dec 3, 2019
@csuzhangxc csuzhangxc removed the needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated label Mar 13, 2020
@csuzhangxc csuzhangxc added the already-update-release-note The release note is updated. Add this label once the release note is updated label Mar 13, 2020
lichunzhu pushed a commit to lichunzhu/dm that referenced this pull request Apr 6, 2020
@csuzhangxc
*: use IsRetryableError in tidb-tools (pingcap#390)
6474c2a
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amyangfei amyangfei amyangfei approved these changes

@WangXiangUSTC WangXiangUSTC Awaiting requested review from WangXiangUSTC

Assignees
No one assigned
Labels
already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked already-update-release-note The release note is updated. Add this label once the release note is updated priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/bug-fix Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@csuzhangxc @WangXiangUSTC @sre-bot @amyangfei @ericsyh