Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

pkg: support to sync alter database DDL #388

Merged
merged 1 commit into from
Dec 2, 2019
Merged

pkg: support to sync alter database DDL #388

merged 1 commit into from
Dec 2, 2019

Conversation

amyangfei
Copy link
Contributor

What problem does this PR solve?

TiDB supports ALTER DATABASE now, remove it in DM default filter

What is changed and how it works?

remove alter database from builtInSkipDDLs

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

@amyangfei amyangfei added type/enhancement Performance improvement or refactoring needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 labels Dec 2, 2019
@amyangfei
Copy link
Contributor Author

/run-all-tests tidb=release-3.0

@codecov
Copy link

codecov bot commented Dec 2, 2019

Codecov Report

Merging #388 into master will increase coverage by 0.0584%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master       #388        +/-   ##
================================================
+ Coverage   57.6018%   57.6602%   +0.0584%     
================================================
  Files           163        163                
  Lines         16496      16455        -41     
================================================
- Hits           9502       9488        -14     
+ Misses         6068       6044        -24     
+ Partials        926        923         -3

@WangXiangUSTC
Copy link
Contributor

LGTM

@WangXiangUSTC WangXiangUSTC added the status/LGT1 One reviewer already commented LGTM label Dec 2, 2019
csuzhangxc
csuzhangxc approved these changes Dec 2, 2019
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Dec 2, 2019
@amyangfei amyangfei merged commit 2cb32a3 into pingcap:master Dec 2, 2019
@amyangfei amyangfei deleted the support-alter-database branch December 2, 2019 03:46
@sre-bot sre-bot mentioned this pull request Dec 2, 2019
Merged
@sre-bot
Copy link

sre-bot commented Dec 2, 2019

cherry pick to release-1.0 in PR #389

@sre-bot sre-bot added already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 labels Dec 2, 2019
@csuzhangxc csuzhangxc added this to the v1.0.3 milestone Dec 2, 2019
@ericsyh ericsyh removed this from the v1.0.3 milestone Dec 3, 2019
@csuzhangxc csuzhangxc added already-update-release-note The release note is updated. Add this label once the release note is updated and removed needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Mar 13, 2020
lichunzhu pushed a commit to lichunzhu/dm that referenced this pull request Apr 6, 2020
@amyangfei
pkg: support to sync alter database DDL (pingcap#388)
3792db8
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked already-update-release-note The release note is updated. Add this label once the release note is updated status/LGT2 Two reviewers already commented LGTM, ready for merge type/enhancement Performance improvement or refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amyangfei @WangXiangUSTC @sre-bot @csuzhangxc @ericsyh