Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

release-1.0: upgrade golang and module #362

Merged
merged 3 commits into from
Nov 19, 2019

Conversation

csuzhangxc
Copy link
Member

@csuzhangxc csuzhangxc commented Nov 16, 2019

What problem does this PR solve?

  • upgrade golang to 1.13
  • upgrade some modules

the PR for master branch is #360, but can not cherry-pick from the master, because etcd not used directly in release-1.0.

What is changed and how it works?

  • update golang version to 1.13 (to compatible with TiDB, PD)
  • update go modules
go get -u github.com/pingcap/tidb@b274eb2
go get -u github.com/pingcap/tidb-tools@48d5e90
go get -u github.com/pingcap/parser@3b43b46
go get -u github.com/pingcap/pd@2488cb9
go get -u go.etcd.io/etcd@3cf2f69
go mod tidy

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

@csuzhangxc csuzhangxc added priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/enhancement Performance improvement or refactoring labels Nov 16, 2019
@csuzhangxc
Copy link
Member Author

/run-all-tests tidb=release-3.0

@codecov
Copy link

codecov bot commented Nov 16, 2019

Codecov Report

❗ No coverage uploaded for pull request base (release-1.0@cf7cbe2). Click here to learn what that means.
The diff coverage is 11.1111%.

@@               Coverage Diff                @@
##             release-1.0       #362   +/-   ##
================================================
  Coverage               ?   57.4135%           
================================================
  Files                  ?        158           
  Lines                  ?      16045           
  Branches               ?          0           
================================================
  Hits                   ?       9212           
  Misses                 ?       5928           
  Partials               ?        905

@csuzhangxc
Copy link
Member Author

@GregoryIan @WangXiangUSTC PTAL

@csuzhangxc
Copy link
Member Author

/run-all-tests tidb=release-3.0

Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Nov 18, 2019
Copy link
Collaborator

@IANTHEREAL IANTHEREAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IANTHEREAL IANTHEREAL added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Nov 19, 2019
@IANTHEREAL IANTHEREAL merged commit 8a15d7c into pingcap:release-1.0 Nov 19, 2019
@csuzhangxc csuzhangxc deleted the upgrade-golang branch November 20, 2019 02:08
@ericsyh ericsyh added this to the v1.0.2 milestone Nov 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/enhancement Performance improvement or refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants