This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 188
*: fix executing shard DDL with mismatched request (#336) #338
Merged
csuzhangxc
merged 10 commits into
pingcap:release-1.0
from
sre-bot:release-1.0-8b2f08e84f49
Oct 28, 2019
Merged
*: fix executing shard DDL with mismatched request (#336) #338
csuzhangxc
merged 10 commits into
pingcap:release-1.0
from
sre-bot:release-1.0-8b2f08e84f49
Oct 28, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sre-bot
added
priority/important
Major change, requires approval from ≥2 primary reviewers
priority/release-blocker
This PR blocks a release. Please review it ASAP.
needs-update-release-note
This PR should be added into release notes. Remove this label once the release notes are updated
type/bug-fix
Bug fix
type/cherry-pick
This PR is just a cherry-pick (backport)
labels
Oct 28, 2019
Codecov Report
@@ Coverage Diff @@
## release-1.0 #338 +/- ##
=============================================
Coverage 60.147% 60.147%
=============================================
Files 135 135
Lines 15236 15236
=============================================
Hits 9164 9164
Misses 5173 5173
Partials 899 899 |
LGTM |
amyangfei
approved these changes
Oct 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
amyangfei
added
status/LGT2
Two reviewers already commented LGTM, ready for merge
and removed
status/LGT1
One reviewer already commented LGTM
labels
Oct 28, 2019
csuzhangxc
added
already-update-release-note
The release note is updated. Add this label once the release note is updated
and removed
needs-update-release-note
This PR should be added into release notes. Remove this label once the release notes are updated
labels
Nov 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
already-update-release-note
The release note is updated. Add this label once the release note is updated
priority/important
Major change, requires approval from ≥2 primary reviewers
priority/release-blocker
This PR blocks a release. Please review it ASAP.
status/LGT2
Two reviewers already commented LGTM, ready for merge
type/bug-fix
Bug fix
type/cherry-pick
This PR is just a cherry-pick (backport)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #336 to release-1.0
What problem does this PR solve?
ExecDDLRequest
from the DM-masterExecDDLRequest
to DM-worker (in order to support re-fetching DDL info from DM-worker after DM-master restarted)example:
ADD INDEX idx1
ADD INDEX idx1
request sentADD COLUMN c1
synced in DM-workerADD COLUMN c1
executed, butADD COLUMN c1
in other DM-workers not synced yet.ref: https://internal.pingcap.net/jira/browse/ONCALL-745
What is changed and how it works?
invalid connection
forADD INDEX
Check List
Tests
Related changes