This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
*: only retry for special message with 1105 #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csuzhangxc
added
priority/normal
Codecov Report
@@ Coverage Diff @@
## master #330 +/- ##
================================================
- Coverage 59.9177% 59.8898% -0.0279%
================================================
Files 135 135
Lines 15079 15076 -3
================================================
- Hits 9035 9029 -6
- Misses 5163 5167 +4
+ Partials 881 880 -1 |
|
@WangXiangUSTC @amyangfei PTAL |
| @@ -238,7 +238,7 @@ func (conn *DBConn) executeSQLWithIgnore(tctx *tcontext.Context, ignoreError fun | |||
| sqlRetriesTotal.WithLabelValues("stmt_exec", conn.cfg.Name).Add(1) | |||
| return true | |||
| } | |||
| if retry.IsRetryableErrorFastFailFilter(err) { | |||
| if retry.IsRetryableError(err) { | |||
There was a problem hiding this comment.
why change to this function? seems change retry logic for ddl
There was a problem hiding this comment.
IsRetryableErrorFastFailFilter as a black-list for 1105, but we have changed to use a white-list for 1105 now.
so, the fast fail error in IsRetryableErrorFastFailFilter will not be retry in IsRetryableError.
UnsupportedDDLMsgs still not be retry.
|
LGTM |
WangXiangUSTC
added
status/LGT1
amyangfei
added
status/LGT2
|
cherry pick to release-1.0 in PR #332 |
sre-bot
added
already-cherry-pick-1.0
amyangfei
pushed a commit
that referenced
this pull request
Oct 23, 2019
csuzhangxc
added
already-update-release-note
lichunzhu
pushed a commit
to lichunzhu/dm
that referenced
this pull request
Apr 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
1105means an unknown error in MySQL/TiDB. some of these errors are retryable, but some are not (likeerror="Error 1105: statement count 5001 exceeds the transaction limitation).What is changed and how it works?
only retry for retryable errors, now including:
Information schema is out of dateInformation schema is changedCheck List
Tests
Related changes