-
Notifications
You must be signed in to change notification settings - Fork 188
worker: generate index flavor automatically by querying version info from DB #323
worker: generate index flavor automatically by querying version info from DB #323
Conversation
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #323 +/- ##
================================================
+ Coverage 59.8923% 59.9177% +0.0254%
================================================
Files 135 135
Lines 15047 15079 +32
================================================
+ Hits 9012 9035 +23
- Misses 5159 5163 +4
- Partials 876 881 +5 |
@lichunzhu I found Can this ( |
@csuzhangxc It works if we suppose customers only use mariaDB and mysql.
mariaDB might be like:
If there is a kind of database which supports |
…orker/simplifyFlavor
I think it's fine now, if neither |
So shall we change |
I think to change to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-Authored-By: Xuecheng Zhang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cherry pick to release-1.0 failed |
…from DB (pingcap#323) use dbutil.ShowVersion and check.IsMariaDB from tidb-tools to detect upstream MySQL/MariaDB server type and set flavor automatically.
What problem does this PR solve?
Now, we need to set flavor for DM-worker manually, but it may be set incorrectly.
What is changed and how it works?
use
dbutil.ShowVersion
andcheck.IsMariaDB
from tidb-tools to detect upstream MySQL/MariaDB server type and set flavor automatically.Check List
Tests
Related changes