Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

master: only fetch necessary DM-worker's config (#316) #319

Merged
merged 4 commits into from
Oct 17, 2019
Merged

master: only fetch necessary DM-worker's config (#316) #319

merged 4 commits into from
Oct 17, 2019

Conversation

sre-bot
Copy link

@sre-bot sre-bot commented Oct 17, 2019

cherry-pick #316 to release-1.0

What problem does this PR solve?

The previous version of DM-master always fetches all DM-workers' config when starting a task.

When having any un-accessible DM-worker, then we can't start any task.

What is changed and how it works?

Change to only fetches necessary DM-workers' config

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    • start task with un-accessible DM-worker

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@sre-bot sre-bot mentioned this pull request Oct 17, 2019
Merged
@sre-bot sre-bot added priority/normal Minor change, requires approval from ≥1 primary reviewer priority/release-blocker This PR blocks a release. Please review it ASAP. needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport) labels Oct 17, 2019
@sre-bot sre-bot requested a review from amyangfei October 17, 2019 06:45
@WangXiangUSTC
Copy link
Contributor

LGTM

@WangXiangUSTC WangXiangUSTC added the status/LGT1 One reviewer already commented LGTM label Oct 17, 2019
amyangfei
amyangfei approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei amyangfei added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Oct 17, 2019
@codecov
Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #319 into release-1.0 will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           release-1.0       #319   +/-   ##
==============================================
  Coverage      60.6466%   60.6466%           
==============================================
  Files              134        134           
  Lines            14845      14845           
==============================================
  Hits              9003       9003           
  Misses            4972       4972           
  Partials           870        870

@amyangfei amyangfei merged commit 50c4a14 into pingcap:release-1.0 Oct 17, 2019
@csuzhangxc csuzhangxc added already-update-release-note The release note is updated. Add this label once the release note is updated and removed needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amyangfei amyangfei amyangfei approved these changes

Assignees
No one assigned
Labels
already-update-release-note The release note is updated. Add this label once the release note is updated priority/normal Minor change, requires approval from ≥1 primary reviewer priority/release-blocker This PR blocks a release. Please review it ASAP. status/LGT2 Two reviewers already commented LGTM, ready for merge type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sre-bot @WangXiangUSTC @amyangfei @csuzhangxc