Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

task config: add thread config for mydumper, loader and syncer (#309) #314

Merged
merged 8 commits into from
Oct 16, 2019
Merged

task config: add thread config for mydumper, loader and syncer (#309) #314

merged 8 commits into from
Oct 16, 2019

Conversation

sre-bot
Copy link

@sre-bot sre-bot commented Oct 16, 2019

cherry-pick #309 to release-1.0

What problem does this PR solve?

add new config to make the basic config simple

What is changed and how it works?

add new config mydumper-thread, loader-thread and syncer-thread

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@sre-bot sre-bot mentioned this pull request Oct 16, 2019
Merged
@sre-bot sre-bot added priority/normal Minor change, requires approval from ≥1 primary reviewer priority/release-blocker This PR blocks a release. Please review it ASAP. needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated type/cherry-pick This PR is just a cherry-pick (backport) labels Oct 16, 2019
csuzhangxc
csuzhangxc reviewed Oct 16, 2019
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added the status/LGT1 One reviewer already commented LGTM label Oct 16, 2019
@codecov
Copy link

codecov bot commented Oct 16, 2019

Codecov Report

❗ No coverage uploaded for pull request base (release-1.0@db4cb60). Click here to learn what that means.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             release-1.0       #314   +/-   ##
================================================
  Coverage               ?   60.5868%           
================================================
  Files                  ?        134           
  Lines                  ?      14825           
  Branches               ?          0           
================================================
  Hits                   ?       8982           
  Misses                 ?       4974           
  Partials               ?        869

lichunzhu
lichunzhu approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lichunzhu lichunzhu merged commit ab13ec3 into pingcap:release-1.0 Oct 16, 2019
@csuzhangxc csuzhangxc added already-update-release-note The release note is updated. Add this label once the release note is updated and removed needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Nov 1, 2019
@csuzhangxc csuzhangxc added already-update-docs The docs related to this PR already updated. Add this label once the docs are updated and removed needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated labels Mar 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@lichunzhu lichunzhu lichunzhu approved these changes

@ericsyh ericsyh Awaiting requested review from ericsyh

Assignees
No one assigned
Labels
already-update-docs The docs related to this PR already updated. Add this label once the docs are updated already-update-release-note The release note is updated. Add this label once the release note is updated priority/normal Minor change, requires approval from ≥1 primary reviewer priority/release-blocker This PR blocks a release. Please review it ASAP. status/LGT1 One reviewer already commented LGTM type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sre-bot @csuzhangxc @lichunzhu @WangXiangUSTC