Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

*: add print sample config #28

Merged
merged 11 commits into from
Jan 28, 2019
Merged

*: add print sample config #28

merged 11 commits into from
Jan 28, 2019

Conversation

IANTHEREAL
Copy link
Collaborator

@IANTHEREAL IANTHEREAL commented Jan 25, 2019 •
edited
Loading

What problem does this PR solve?

let user easy to find sample config file

What is changed and how it works?

  • add description in README.md
  • add --print-sample-config in dm-worker and dm-master

Check List

Tests

  • Manual test (add detailed scripts or steps below)

# Master Configuration.

// log configuration
log-level = "info"
log-file = "dm-master.log"

// dm-master listen address
master-addr = ":8261"

# replication group <-> dm-Worker deployment, we'll refine it when new deployment function is available
[[deploy]]
source-id = "mysql-replica-01"
dm-worker = "172.16.10.72:8262"

[[deploy]]
source-id = "mysql-replica-02"
dm-worker = "172.16.10.73:8262"

@IANTHEREAL IANTHEREAL added priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/doc Documentation changes in this repro labels Jan 25, 2019
@IANTHEREAL
Copy link
Collaborator Author

/run-all-tests

1 similar comment
@IANTHEREAL
Copy link
Collaborator Author

/run-all-tests

csuzhangxc
csuzhangxc reviewed Jan 25, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
dm/master/config.go Show resolved Hide resolved
@IANTHEREAL
Copy link
Collaborator Author

/run-all-tests

@CLAassistant
Copy link

CLAassistant commented Jan 26, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

amyangfei
amyangfei reviewed Jan 27, 2019
View reviewed changes
dm/master/dm-master.toml Outdated
@@ -1,13 +1,13 @@
# Master Configuration.

// log configuration
Copy link
Contributor

@amyangfei amyangfei Jan 27, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

toml file uses # as comment leading?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep I would fix it

csuzhangxc
csuzhangxc reviewed Jan 27, 2019
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@csuzhangxc
Copy link
Member

LGTM

@amyangfei
Copy link
Contributor

LGTM

@amyangfei amyangfei added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Jan 28, 2019
@IANTHEREAL IANTHEREAL merged commit a6a839c into pingcap:master Jan 28, 2019
@IANTHEREAL IANTHEREAL deleted the ian/master branch January 28, 2019 02:28
lichunzhu pushed a commit to lichunzhu/dm that referenced this pull request Apr 6, 2020
@IANTHEREAL
*: add print sample config (pingcap#28)
a6da88c
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@amyangfei amyangfei amyangfei left review comments

Assignees
No one assigned
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/doc Documentation changes in this repro
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IANTHEREAL @CLAassistant @csuzhangxc @amyangfei