This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
worker: fix panic in handle task #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyangfei
added
priority/normal
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #225 +/- ##
===============================================
- Coverage 59.155% 59.0685% -0.0866%
===============================================
Files 125 123 -2
Lines 14320 14214 -106
===============================================
- Hits 8471 8396 -75
+ Misses 4996 4960 -36
- Partials 853 858 +5 |
amyangfei
added
the
status/PTAL
|
Good Job! LGTM |
IANTHEREAL
added
priority/important
csuzhangxc
reviewed
Aug 6, 2019
dm/worker/worker.go
Outdated
| failpoint.Inject("handleTaskInternal", func(val failpoint.Value) { | ||
| if milliseconds, ok := val.(int); ok { | ||
| handleTaskInterval = time.Duration(milliseconds) * time.Millisecond | ||
| w.l.Info("set handleTaskInterval", zap.Int("value", milliseconds)) |
There was a problem hiding this comment.
log a field with failpoint key like other failpoint inject?
csuzhangxc
added
status/LGT2
amyangfei
removed
the
status/PTAL
lichunzhu
pushed a commit
to lichunzhu/dm
that referenced
this pull request
Apr 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix a panic bug in dm task hander
We can reproduce the panic with steps as follows:
stop-task,pause-taskorresume-taskfrom DM-masterWhat is changed and how it works?
If task meta is not stored in DM-worker's memory when we want to use it, log a warning message instead of using it.
Check List
Tests
Code changes
Side effects
Related changes