This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
*: Use insert for non safe-mode instead of replace #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
|
/run-all-tests |
1. if exits in sharindg resync, safe mode must be enabled. 2. if exits before sharding ddl executes, we first flush checkpoints to avoid DML reentrance after DDL owner restarts. 3. we check safe mode in scenario 2 only, as in scenario it is always true
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #199 +/- ##
===========================================
Coverage 59.0651% 59.0651%
===========================================
Files 123 123
Lines 14440 14440
===========================================
Hits 8529 8529
Misses 5050 5050
Partials 861 861 |
july2993
added
status/PTAL
july2993
requested review from
csuzhangxc and
amyangfei
and removed request for
csuzhangxc
amyangfei
added
priority/normal
|
PTAL @csuzhangxc |
csuzhangxc
added
status/LGT2
lichunzhu
pushed a commit
to lichunzhu/dm
that referenced
this pull request
Apr 6, 2020
also fix fix safe mode test case: 1. if exits in sharindg resync, safe mode must be enabled. 2. if exits before sharding ddl executes, we first flush checkpoints to avoid DML reentrance after DDL owner restarts. 3. we check safe mode in scenario 2 only, as in scenario it is always true
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
*: Use insert for non safe-mode instead of replace
What is changed and how it works?
check safe-mode as update event, and use insert for non safe-mode instead of replace
Check List
Tests
Code changes
Side effects
Related changes