Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

syncer: support case insensitive binlog event in filter #188

Merged
merged 2 commits into from
Jun 26, 2019

Conversation

amyangfei
Copy link
Contributor

@amyangfei amyangfei commented Jun 26, 2019

What problem does this PR solve?

support case insensitive binlog event in binlog event filter. fix issue #181

What is changed and how it works?

upgrade the version of tidb-tools to this commit https://github.com/pingcap/tidb-tools/tree/16523947c844b1b1aa2996f56dbdc4251bb5c452

Check List

Tests

  • Unit test

@amyangfei amyangfei added priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/enhancement Performance improvement or refactoring labels Jun 26, 2019
@codecov
Copy link

codecov bot commented Jun 26, 2019

Codecov Report

Merging #188 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master       #188   +/-   ##
===========================================
  Coverage   53.2547%   53.2547%           
===========================================
  Files           121        121           
  Lines         13826      13826           
===========================================
  Hits           7363       7363           
  Misses         5717       5717           
  Partials        746        746

@WangXiangUSTC
Copy link
Contributor

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Jun 26, 2019
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei amyangfei added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Jun 26, 2019
@amyangfei amyangfei merged commit 0ba5300 into pingcap:master Jun 26, 2019
@amyangfei amyangfei deleted the case-insensitive-binlog-event branch June 26, 2019 08:25
lichunzhu pushed a commit to lichunzhu/dm that referenced this pull request Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/enhancement Performance improvement or refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants