This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
shardddl/optimistic: use init-schema for table without info when recover lock (#1551) #1553
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #1551 to release-2.0
You can switch your code base to this Pull Request by using git-extras:
# In dm repo: git pr https://github.com/pingcap/dm/pull/1553
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
In #1518, we always use table-info-before to rebuild locks, but ignore the upstream table who has no optimism.Info. In such a case, we may build an incorrect joined table.
Suppose there are two upstream tables tb1(a int, b int, c int) and tb2(a int, b int, c int). A possible time series is:
What is changed and how it works?
Use init-schema for table without info when recover lock. If there is no optimism.Info for a upstream table, it indicates the table structure hasn't been changed since last removeLock. So the init schema should be its table info.
Check List
Tests