-
Notifications
You must be signed in to change notification settings - Fork 188
test: fix unstabled drop then add column #1548
Conversation
another unstable test, maybe I should fix it in this PR https://internal.pingcap.net/idc-jenkins/blue/organizations/jenkins/dm_ghpr_test/detail/dm_ghpr_test/8648/pipeline/87 |
/hold |
This comment has been minimized.
This comment has been minimized.
there's no between
(DM master restart) and
|
/unhold |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
"run_sql_source1 \"create table ${shardddl1}.${tb1} (a int primary key, b int, c int);\"; \ | ||
run_sql_source2 \"create table ${shardddl1}.${tb1} (a int primary key, b int, c int);\"" \ | ||
"clean_table" "optimistic" "$i" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"run_sql_source1 \"create table ${shardddl1}.${tb1} (a int primary key, b int, c int);\"; \ | |
run_sql_source2 \"create table ${shardddl1}.${tb1} (a int primary key, b int, c int);\"" \ | |
"clean_table" "optimistic" "$i" | |
"run_sql_source1 \"create table ${shardddl1}.${tb1} (a int primary key, b int, c int);\"; \ | |
run_sql_source2 \"create table ${shardddl1}.${tb1} (a int primary key, b int, c int);\"" \ | |
"clean_table" "optimistic" "$i" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 5c8f022
|
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-2.0 in PR #1549 |
What problem does this PR solve?
fix #1540 (comment)
What is changed and how it works?
move add column after a sync-diff check
Check List
Tests
Code changes
Side effects
Related changes