Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

test: align with TiDB clustered index behaviour #1538

Merged
merged 2 commits into from
Mar 29, 2021

Conversation

lance6716
Copy link
Collaborator

What problem does this PR solve?

revert some of #1522

What is changed and how it works?

Check List

Tests

  • No code

Related changes

  • Need to cherry-pick to the release branch

@lance6716 lance6716 added the needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 label Mar 28, 2021
@ti-chi-bot ti-chi-bot requested review from GMHDBJD and lichunzhu March 28, 2021 07:26
@lance6716 lance6716 added the status/PTAL This PR is ready for review. Add this label back after committing new changes label Mar 28, 2021
@GMHDBJD
Copy link
Collaborator

GMHDBJD commented Mar 29, 2021

Should we enable alter-primary-key in schemaTracker?

@lance6716
Copy link
Collaborator Author

Should we enable alter-primary-key in schemaTracker?

I want to set OFF clustered index in another PR, so in future we don't need to change again when update TiDB

@GMHDBJD
Copy link
Collaborator

GMHDBJD commented Mar 29, 2021

I want to set OFF clustered index in another PR, so in future we don't need to change again when update TiDB

Maybe we should set it the same as downstream?

@lance6716
Copy link
Collaborator Author

I want to set OFF clustered index in another PR, so in future we don't need to change again when update TiDB

Maybe we should set it the same as downstream?

downstream may change global variable of clustered index and rebuild the table, at that time schema tracker has no way to know that change. I prefer keep schema tracker maximum compatibility of DDL.

@GMHDBJD
Copy link
Collaborator

GMHDBJD commented Mar 29, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label Mar 29, 2021
@GMHDBJD
Copy link
Collaborator

GMHDBJD commented Mar 29, 2021

Will a create table stmt create table tb(id int) from upstream become create table tb(id int nonclustered) in tracker and exec to TiDB if we set clustered index OFF

@lichunzhu
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Mar 29, 2021
@lance6716
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 59bb238

@ti-chi-bot ti-chi-bot merged commit 415e713 into pingcap:master Mar 29, 2021
ti-srebot pushed a commit to ti-srebot/dm that referenced this pull request Mar 29, 2021
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #1539

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked size/S status/can-merge status/LGT2 Two reviewers already commented LGTM, ready for merge status/PTAL This PR is ready for review. Add this label back after committing new changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants