Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

operate-schema: flush schema info and sync to master in optimistic mode (#1506) #1514

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

ti-srebot
Copy link

@ti-srebot ti-srebot commented Mar 18, 2021

cherry-pick #1506 to release-2.0
You can switch your code base to this Pull Request by using git-extras:

# In dm repo:
git pr https://github.com/pingcap/dm/pull/1514

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/dm.git pr/1514:release-2.0-976688affd66

What problem does this PR solve?

handle rename column statement

What is changed and how it works?

  • add --flush and --sync for operate-schema set
  • flush checkpoint and table info
  • sync table info to master and ignore conflict in optimistic mode

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change

@ti-srebot ti-srebot added needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick This PR is just a cherry-pick (backport) labels Mar 18, 2021
@lance6716
Copy link
Collaborator

/lgtm

@ti-srebot ti-srebot added the status/LGT1 One reviewer already commented LGTM label Mar 18, 2021
@lance6716 lance6716 merged commit da1565c into pingcap:release-2.0 Mar 19, 2021
@lance6716 lance6716 removed the needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated label May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated status/LGT1 One reviewer already commented LGTM status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants