Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

loader: don't use ANSI_QUOTES for dumped data files (#1497) #1498

Merged
merged 1 commit into from
Mar 10, 2021

Conversation

ti-srebot
Copy link

@ti-srebot ti-srebot commented Mar 10, 2021

cherry-pick #1497 to release-2.0
You can switch your code base to this Pull Request by using git-extras:

# In dm repo:
git pr https://github.com/pingcap/dm/pull/1498

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/dm.git pr/1498:release-2.0-a2363844372c

What problem does this PR solve?

in #1309, condition branch of dumped data file is not tested because of column-mapping, and it has a BUG

What is changed and how it works?

don't use ANSI_QUOTES for dumped data files

Check List

Tests

  • Integration test

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@ti-srebot ti-srebot added needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated type/cherry-pick This PR is just a cherry-pick (backport) labels Mar 10, 2021
@ti-srebot ti-srebot requested a review from GMHDBJD March 10, 2021 10:47
@lance6716 lance6716 merged commit 35304f2 into pingcap:release-2.0 Mar 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants