This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
config: disable heartbeat feature #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance6716
added
needs-cherry-pick-release-2.0
GMHDBJD
reviewed
Mar 1, 2021
| @@ -626,7 +626,9 @@ func (c *TaskConfig) SubTaskConfigs(sources map[string]DBConfig) ([]*SubTaskConf | |||
| cfg.Mode = c.TaskMode | |||
| cfg.CaseSensitive = c.CaseSensitive | |||
| cfg.MetaSchema = c.MetaSchema | |||
| cfg.EnableHeartbeat = c.EnableHeartbeat | |||
There was a problem hiding this comment.
How about set it false explicitly.
|
Will there be the same problem when upgrading from v1 to v2 via tiup？ |
I think the |
Seems the |
updated in 453f2b3 |
|
/lgtm |
lichunzhu
added
status/LGT2
ti-srebot
pushed a commit
to ti-srebot/dm
that referenced
this pull request
Mar 8, 2021
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-2.0 in PR #1486 |
ti-srebot
added
the
already-cherry-pick-2.0
ti-srebot
removed
the
needs-cherry-pick-release-2.0
lance6716
pushed a commit
that referenced
this pull request
Mar 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
close #1423
What is changed and how it works?
overwrite it to
falseCheck List
Tests
Code changes
Side effects
Related changes