Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

gtid, relay: use gtid_purged to handle gap in Previous_gtids event (#1430) #1441

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

ti-srebot
Copy link

@ti-srebot ti-srebot commented Feb 19, 2021

cherry-pick #1430 to release-2.0
You can switch your code base to this Pull Request by using git-extras:

# In dm repo:
git pr https://github.com/pingcap/dm/pull/1441

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/dm.git pr/1441:release-2.0-c32de2423541

What problem does this PR solve?

part of #1418 (we need to test master-slave upstream manually later)

What is changed and how it works?

remove ResetStart, instead, query @@gtid_purged and combine it to gtid set when needed

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change
  • Has interface methods change

Side effects

  • Potential performance regression

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@ti-srebot ti-srebot added needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick This PR is just a cherry-pick (backport) labels Feb 19, 2021
@lance6716 lance6716 merged commit 1235c74 into pingcap:release-2.0 Feb 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants