Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

worker, ha: increase keepalive TTL to 1 minute, and to 30 minutes if relay enabled (#1405) #1426

Merged
merged 2 commits into from
Feb 4, 2021

Conversation

ti-srebot
Copy link

@ti-srebot ti-srebot commented Feb 4, 2021

cherry-pick #1405 to release-2.0
You can switch your code base to this Pull Request by using git-extras:

# In dm repo:
git pr https://github.com/pingcap/dm/pull/1426

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/dm.git pr/1426:release-2.0-50876d3d597a

What problem does this PR solve?

make keepalive more rubost

What is changed and how it works?

after this PR there're two keepalive TTL: one for relay and one for non-relay. They are 30 minutes and 1 minute seperately by default.
If relay task is assigned, change it to relay-keepalive-ttl, when no relay tasks, chage it to keepalive-ttl

Check List

Tests

  • Integration test

Code changes

  • Has exported function/method change

Side effects

  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@ti-srebot ti-srebot added needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick This PR is just a cherry-pick (backport) labels Feb 4, 2021
@ti-srebot ti-srebot requested a review from lichunzhu February 4, 2021 07:49
@lance6716 lance6716 merged commit 5148b76 into pingcap:release-2.0 Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants