This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
worker, ha: For errors that can only be attempted a limited number of times, the number of attempts is limited #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lance6716
added
needs-cherry-pick-release-2.0
lance6716
reviewed
Jan 29, 2021
dm/worker/server.go
Outdated
| select { | ||
| case <-s.ctx.Done(): | ||
| return | ||
| case <-time.After(keepaliveTimeout): |
There was a problem hiding this comment.
sleep time should be related to s.cfg.KeepAliveTTL, for example, 2 * s.cfg.KeepAliveTTL
lance6716
changed the title
|
/lgtm |
|
and please help check other |
|
PTAL @3pointer @lichunzhu |
lichunzhu
reviewed
Feb 2, 2021
| @@ -110,7 +110,7 @@ func (s *Server) KeepAlive() { | |||
| return // return if failed to stop the worker. | |||
| } | |||
| select { | |||
| case <-s.ctx.Done(): | |||
There was a problem hiding this comment.
Suggest using another variable to save s.ctx here to avoid data race.
dm/worker/server.go
Outdated
| select { | ||
| case <-s.ctx.Done(): | ||
| return | ||
| case <-time.After(time.Duration(s.cfg.KeepAliveTTL) * time.Second * 2): |
There was a problem hiding this comment.
Can we start another keepalive only when we assure the last one is quitted? For example, using another waitgroup.
|
/lgtm |
ti-srebot
approved these changes
Feb 4, 2021
ti-srebot
added
the
status/LGT2
ti-srebot
pushed a commit
to ti-srebot/dm
that referenced
this pull request
Feb 4, 2021
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-2.0 in PR #1425 |
ti-srebot
added
already-cherry-pick-2.0
lance6716
pushed a commit
that referenced
this pull request
Feb 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
worker recieved a bound watch, but failed to read bound information in etcd.[part of #1388] (#1388)
What is changed and how it works?
Add reading bound information failed error to RetryableError type, but limit the number of retry.
Check List
Tests
Code changes
Side effects
Related changes