Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

bug-fix: no need to check gtid of Mariadb #1335

Merged
merged 9 commits into from
Dec 17, 2020
Merged

bug-fix: no need to check gtid of Mariadb #1335

merged 9 commits into from
Dec 17, 2020

Conversation

GMHDBJD
Copy link
Collaborator

@GMHDBJD GMHDBJD commented Dec 14, 2020 •
edited
Loading

What problem does this PR solve?

close #1319

What is changed and how it works?

  • fix gitd check of Mariadb
  • better incompatible ddl error message
  • test for auto sql_mode
    TODO:
    add mariadb test for integration test or chaos test

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)
    deploy mariadb locally and run integration test

@GMHDBJD GMHDBJD added priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Dec 14, 2020
@GMHDBJD GMHDBJD added this to the v2.0.1 milestone Dec 14, 2020
csuzhangxc
csuzhangxc reviewed Dec 14, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

dm/config/source_config.go Outdated Show resolved Hide resolved
csuzhangxc
csuzhangxc reviewed Dec 14, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Dec 14, 2020
lance6716
lance6716 reviewed Dec 14, 2020
View reviewed changes
Copy link
Collaborator

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM, waiting comments to be addressed

tests/sharding/run.sh Show resolved Hide resolved
dm/config/source_config.go Show resolved Hide resolved
@lance6716 lance6716 added the needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated label Dec 14, 2020
lance6716
lance6716 approved these changes Dec 17, 2020
View reviewed changes
Copy link
Collaborator

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lance6716 lance6716 added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Dec 17, 2020
@lance6716 lance6716 merged commit 9db0da1 into pingcap:master Dec 17, 2020
@ti-srebot ti-srebot mentioned this pull request Dec 17, 2020
Merged
ti-srebot pushed a commit to ti-srebot/dm that referenced this pull request Dec 17, 2020
@GMHDBJD @ti-srebot
cherry pick pingcap#1335 to release-2.0
8e63bb0 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #1344

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Dec 17, 2020
GMHDBJD pushed a commit that referenced this pull request Dec 21, 2020
@ti-srebot
cherry pick #1335 to release-2.0 (#1344)
5dd474f
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/bug-fix Bug fix
Projects
None yet
Milestone
v2.0.1
Development

Successfully merging this pull request may close these issues.

When Mariadb enable-gtid=true, executing operation-source create failed
4 participants
@GMHDBJD @ti-srebot @lance6716 @csuzhangxc