This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
syncer: do not try to handle jobs anymore if the context is done (#1295) #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <[email protected]>
ti-srebot
added
first-time-contributor
status/PTAL
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
LGTM |
csuzhangxc
added
status/LGT2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #1295 to release-2.0
What problem does this PR solve?
fix #1254
What is changed and how it works?
do not try to handle jobs anymore if the context is done
Check List
Tests
NOTE: this case is hard to test in CI now,
incremental_modemay have a little effect on this.Code changes
Side effects
Related changes