Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

fix: support "sql" prefix exists in table name (#1256) #1259

Merged
merged 1 commit into from
Nov 2, 2020
Merged

fix: support "sql" prefix exists in table name (#1256) #1259

merged 1 commit into from
Nov 2, 2020

Conversation

ti-srebot
Copy link

cherry-pick #1256 to release-2.0

What problem does this PR solve?

fix #1255

What is changed and how it works?

use LastIndex rather than Index to find the index of .sql suffix.

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

@ti-srebot ti-srebot mentioned this pull request Nov 2, 2020
Merged
@ti-srebot ti-srebot added priority/normal Minor change, requires approval from ≥1 primary reviewer type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport) first-time-contributor labels Nov 2, 2020
@lance6716
Copy link
Collaborator

LGTM

@ti-srebot ti-srebot added the status/LGT1 One reviewer already commented LGTM label Nov 2, 2020
csuzhangxc
csuzhangxc approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Nov 2, 2020
@csuzhangxc csuzhangxc added this to the v2.0.1 milestone Nov 2, 2020
@csuzhangxc csuzhangxc merged commit dd8c11a into pingcap:release-2.0 Nov 2, 2020
@csuzhangxc csuzhangxc added the needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated label Nov 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc approved these changes

@GMHDBJD GMHDBJD Awaiting requested review from GMHDBJD

@lance6716 lance6716 Awaiting requested review from lance6716

Assignees
No one assigned
Labels
first-time-contributor needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
v2.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-srebot @lance6716 @csuzhangxc