Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

*: update parser to support GRANT CREATE TABLESPACE syntax (#1048) #1225

Closed

Conversation

ti-srebot
Copy link

cherry-pick #1048 to release-1.0


NOTE: pingcap/parser with pingcap/parser@a60a80d can't works well with pingcap/tidb (at least to the latest of 2020/09/16 with pingcap/tidb@205c401):
- [privilege:8049]mysql.user ("[privilege:8049]mysql.user") reported in session.BootstrapSession.


What problem does this PR solve?

fix #684

What is changed and how it works?

  • update pingcap/parser (then we also need to update pingcap/tidb and pingcap/tidb-tools because errors code has been updated)

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked dependencies Pull requests that update a dependency file priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport) labels Oct 27, 2020
@@ -18,7 +18,11 @@ import (
"github.com/pingcap/errors"
"github.com/pingcap/parser/ast"
tmysql "github.com/pingcap/parser/mysql"
<<<<<<< HEAD
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expected 'STRING', found '<<' (and 10 more errors)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked dependencies Pull requests that update a dependency file first-time-contributor priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants