Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

loader: add lock for memory cached checkpoint (#1145) #1223

Closed

Conversation

ti-srebot
Copy link

cherry-pick #1145 to release-1.0


What problem does this PR solve?

close #1143

What is changed and how it works?

add RWMutex for RemoteCheckPoint.restoringFiles

Check List

Tests

  • pass original test

Code changes

Side effects

  • Possible performance regression (@GMHDBJD )

Related changes

  • Need to cherry-pick to the release branch

@@ -80,7 +80,14 @@ type RemoteCheckPoint struct {
id string
schema string
tableName string // tableName contains schema name
<<<<<<< HEAD
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expected '}', found '<<' (and 7 more errors)

@ti-srebot ti-srebot added first-time-contributor already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked priority/normal Minor change, requires approval from ≥1 primary reviewer type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport) labels Oct 27, 2020
@lance6716 lance6716 closed this Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked first-time-contributor priority/normal Minor change, requires approval from ≥1 primary reviewer type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants