Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

log: fix NaN and Dpanic log #1201 #1209

Merged
merged 1 commit into from
Oct 23, 2020
Merged

log: fix NaN and Dpanic log #1201 #1209

merged 1 commit into from
Oct 23, 2020

Conversation

GMHDBJD
Copy link
Collaborator

@GMHDBJD GMHDBJD commented Oct 23, 2020

What problem does this PR solve?

cherry-pick #1201 to release-2.0

What is changed and how it works?

  • loader progress show NaN % if no data in all tables
  • syncer log Dpanic when create database

Check List

Tests

  • Integration test

@GMHDBJD GMHDBJD added priority/normal Minor change, requires approval from ≥1 primary reviewer type/cherry-pick This PR is just a cherry-pick (backport) labels Oct 23, 2020
csuzhangxc
csuzhangxc approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added the status/LGT1 One reviewer already commented LGTM label Oct 23, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 milestone Oct 23, 2020
@csuzhangxc csuzhangxc merged commit 3701751 into pingcap:release-2.0 Oct 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees
No one assigned
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT1 One reviewer already commented LGTM type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@GMHDBJD @csuzhangxc