Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

fix: accept comands with leading and trailing white spaces (#1200) #1202

Merged
merged 1 commit into from
Oct 22, 2020

Conversation

ti-srebot
Copy link

cherry-pick #1200 to release-2.0


What problem does this PR solve?

exit with trailing white spaces

» exit
Error: unknown command "exit" for "dmctl"
Run 'dmctl --help' for usage.
fail to run: [exit]

exit with leading white spaces

»  exit
Error: unknown command "exit" for "dmctl"
Run 'dmctl --help' for usage.
fail to run: [exit]

What is changed and how it works?

remove leading and trailing white spaces before handling it.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    • re-run commands above

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

@ti-srebot ti-srebot added priority/unimportant Really minor change, requires approval from secondary reviewers first-time-contributor type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport) labels Oct 22, 2020
@ti-srebot ti-srebot requested a review from GMHDBJD October 22, 2020 08:51
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added the status/LGT1 One reviewer already commented LGTM label Oct 22, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 milestone Oct 22, 2020
@csuzhangxc csuzhangxc merged commit f0f5267 into pingcap:release-2.0 Oct 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
first-time-contributor priority/unimportant Really minor change, requires approval from secondary reviewers status/LGT1 One reviewer already commented LGTM type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants