Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

fix: fix wrong shorthand for statement-size #1195

Merged
merged 1 commit into from
Oct 21, 2020
Merged

fix: fix wrong shorthand for statement-size #1195

merged 1 commit into from
Oct 21, 2020

Conversation

csuzhangxc
Copy link
Member

What problem does this PR solve?

in dumpling, we use -s as the shorthand for --statement-size (https://github.com/pingcap/dumpling/blob/270170441a02b0a31ea927ae3ffb13c4acb8dc23/cmd/dumpling/main.go#L102), but we use -S in DM.

What is changed and how it works?

change S to s.

Check List

Tests

  • Unit test

Code changes

  • Has exported variable/fields change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch

@csuzhangxc csuzhangxc added priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix type/compatibility Backward compatibility will be broken after this PR merged needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Oct 21, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 milestone Oct 21, 2020
@csuzhangxc
Copy link
Member Author

/run-all-tests

GMHDBJD
GMHDBJD approved these changes Oct 21, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Oct 21, 2020
@lance6716 lance6716 merged commit cb04cf4 into pingcap:master Oct 21, 2020
ti-srebot pushed a commit to ti-srebot/dm that referenced this pull request Oct 21, 2020
@csuzhangxc @ti-srebot
cherry pick pingcap#1195 to release-2.0
45f1090 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Oct 21, 2020
Merged
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #1196

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Oct 21, 2020
csuzhangxc added a commit that referenced this pull request Oct 21, 2020
@ti-srebot @csuzhangxc
fix: fix wrong shorthand for statement-size (#1195)
097de17 
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: Xuecheng Zhang <[email protected]>
@csuzhangxc csuzhangxc deleted the fix-dumpling-args branch October 21, 2020 10:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT1 One reviewer already commented LGTM type/bug-fix Bug fix type/compatibility Backward compatibility will be broken after this PR merged
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@csuzhangxc @ti-srebot @GMHDBJD @lance6716