Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

syncer: split DDL after fetching online DDL to execute #1184

Merged
merged 4 commits into from
Oct 20, 2020
Merged

syncer: split DDL after fetching online DDL to execute #1184

merged 4 commits into from
Oct 20, 2020

Conversation

lance6716
Copy link
Collaborator

@lance6716 lance6716 commented Oct 19, 2020 •
edited
Loading

What problem does this PR solve?

close #1175

What is changed and how it works?

update parser to pingcap/parser#1061

Check List

Tests

  • Integration test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@lance6716 lance6716 added needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix status/WIP This PR is still work in progress and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Oct 19, 2020
@lance6716
Copy link
Collaborator Author

/run-all-tests

@lance6716 lance6716 added status/PTAL This PR is ready for review. Add this label back after committing new changes and removed status/WIP This PR is still work in progress labels Oct 20, 2020
csuzhangxc
csuzhangxc approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Oct 20, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 milestone Oct 20, 2020
@lance6716 lance6716 merged commit 435aa72 into pingcap:master Oct 20, 2020
ti-srebot pushed a commit to ti-srebot/dm that referenced this pull request Oct 20, 2020
@lance6716 @ti-srebot
cherry pick pingcap#1184 to release-2.0
7438fb1 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Oct 20, 2020
Merged
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #1192

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Oct 20, 2020
csuzhangxc pushed a commit that referenced this pull request Oct 21, 2020
@ti-srebot @lance6716
syncer: split DDL after fetching online DDL to execute (#1184)
fc28d0c 
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: lance6716 <[email protected]>
@csuzhangxc csuzhangxc added already-update-release-note The release note is updated. Add this label once the release note is updated and removed needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked already-update-release-note The release note is updated. Add this label once the release note is updated status/LGT1 One reviewer already commented LGTM type/bug-fix Bug fix
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

may fail to online DDL in some alter case
3 participants
@lance6716 @ti-srebot @csuzhangxc