Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

loader: add lock for memory cached checkpoint (#1145) #1182

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

ti-srebot
Copy link

cherry-pick #1145 to release-2.0


What problem does this PR solve?

close #1143

What is changed and how it works?

add RWMutex for RemoteCheckPoint.restoringFiles

Check List

Tests

  • pass original test

Code changes

Side effects

  • Possible performance regression (@GMHDBJD )

Related changes

  • Need to cherry-pick to the release branch

@ti-srebot ti-srebot added first-time-contributor priority/normal Minor change, requires approval from ≥1 primary reviewer type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport) labels Oct 19, 2020
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc merged commit 1c8bfda into pingcap:release-2.0 Oct 19, 2020
@lance6716 lance6716 added status/PTAL This PR is ready for review. Add this label back after committing new changes and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
first-time-contributor priority/normal Minor change, requires approval from ≥1 primary reviewer type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants