Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

config: check default config #1156

Merged
merged 3 commits into from
Oct 14, 2020
Merged

config: check default config #1156

merged 3 commits into from
Oct 14, 2020

Conversation

lance6716
Copy link
Collaborator

What problem does this PR solve?

close #1130

What is changed and how it works?

till this PR, all default config is checked and should cause no problem (I hope)

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

@lance6716 lance6716 added needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes labels Oct 13, 2020
GMHDBJD
GMHDBJD reviewed Oct 14, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Oct 14, 2020
csuzhangxc
csuzhangxc approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Oct 14, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC.3 milestone Oct 14, 2020
@csuzhangxc csuzhangxc merged commit 15e2507 into pingcap:master Oct 14, 2020
ti-srebot pushed a commit to ti-srebot/dm that referenced this pull request Oct 14, 2020
@lance6716 @ti-srebot
cherry pick pingcap#1156 to release-2.0
260cb4c 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Oct 14, 2020
Merged
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #1159

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Oct 14, 2020
@lance6716 lance6716 deleted the check-default branch October 14, 2020 03:51
csuzhangxc pushed a commit that referenced this pull request Oct 14, 2020
@ti-srebot @lance6716
cherry pick #1156 to release-2.0 (#1159)
c6d2d04 
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: lance6716 <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GMHDBJD GMHDBJD GMHDBJD left review comments

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

set suitable default value for process, source and task config items
4 participants
@lance6716 @ti-srebot @csuzhangxc @GMHDBJD