Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

dep: update dumpling #1132

Merged
merged 3 commits into from
Oct 10, 2020
Merged

dep: update dumpling #1132

merged 3 commits into from
Oct 10, 2020

Conversation

lance6716
Copy link
Collaborator

What problem does this PR solve?

close #1119, part of #1130

What is changed and how it works?

pingcap/dumpling#157 : dumpling add --allow-cleartext-password
pingcap/dumpling#158 : dumpling support dump view, but default don't dump it (need more test to default enable)
pingcap/dumpling#160 : set default statement-size

Check List

Tests

  • No code

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

@lance6716 lance6716 added priority/unimportant Really minor change, requires approval from secondary reviewers status/PTAL This PR is ready for review. Add this label back after committing new changes type/dependencies Pull requests that update a dependency file labels Oct 10, 2020
csuzhangxc
csuzhangxc reviewed Oct 10, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Oct 10, 2020
@lance6716 lance6716 added the needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 label Oct 10, 2020
@GMHDBJD
Copy link
Collaborator

GMHDBJD commented Oct 10, 2020

/run-all-tests

GMHDBJD
GMHDBJD previously approved these changes Oct 10, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Oct 10, 2020
@lance6716
Copy link
Collaborator Author

/run-all-tests

@lance6716
Copy link
Collaborator Author

please Approve since I made some change in CI @csuzhangxc @GMHDBJD

@lance6716 lance6716 merged commit 7038190 into pingcap:master Oct 10, 2020
@lance6716 lance6716 deleted the update-dumpling branch October 10, 2020 07:55
ti-srebot pushed a commit to ti-srebot/dm that referenced this pull request Oct 10, 2020
@lance6716 @ti-srebot
cherry pick pingcap#1132 to release-2.0
92ecb14 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Oct 10, 2020
Merged
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #1133

@csuzhangxc csuzhangxc added this to the v2.0.0 RC.3 milestone Oct 10, 2020
@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Oct 10, 2020
lance6716 pushed a commit that referenced this pull request Oct 10, 2020
@ti-srebot
cherry pick #1132 to release-2.0 (#1133)
91a11ca
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc approved these changes

@GMHDBJD GMHDBJD GMHDBJD left review comments

Assignees
No one assigned
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked priority/unimportant Really minor change, requires approval from secondary reviewers status/LGT2 Two reviewers already commented LGTM, ready for merge type/dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

track dumpling features
4 participants
@lance6716 @GMHDBJD @ti-srebot @csuzhangxc