Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

dumpling: support metadata without GTID #1122

Merged
merged 1 commit into from
Sep 30, 2020
Merged

dumpling: support metadata without GTID #1122

merged 1 commit into from
Sep 30, 2020

Conversation

lance6716
Copy link
Collaborator

What problem does this PR solve?

support metadata without GTID

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

@lance6716 lance6716 added needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 priority/release-blocker This PR blocks a release. Please review it ASAP. status/PTAL This PR is ready for review. Add this label back after committing new changes labels Sep 30, 2020
csuzhangxc
csuzhangxc approved these changes Sep 30, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Sep 30, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC.3 milestone Sep 30, 2020
@lance6716 lance6716 merged commit 3db9f55 into pingcap:master Sep 30, 2020
ti-srebot pushed a commit to ti-srebot/dm that referenced this pull request Sep 30, 2020
@lance6716 @ti-srebot
cherry pick pingcap#1122 to release-2.0
ebad69e 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Sep 30, 2020
Merged
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #1123

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Sep 30, 2020
lance6716 added a commit that referenced this pull request Sep 30, 2020
@ti-srebot @lance6716
cherry pick #1122 to release-2.0 (#1123)
dc033a3 
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: lance6716 <[email protected]>
@lance6716 lance6716 deleted the parse-metadata branch July 6, 2021 02:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked priority/release-blocker This PR blocks a release. Please review it ASAP. status/LGT1 One reviewer already commented LGTM
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lance6716 @ti-srebot @csuzhangxc