Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

tracker: fetch ref table at CREATE LIKE and more (#1105) #1108

Merged
merged 11 commits into from
Sep 28, 2020
Merged

tracker: fetch ref table at CREATE LIKE and more (#1105) #1108

merged 11 commits into from
Sep 28, 2020

Conversation

ti-srebot
Copy link

cherry-pick #1105 to release-2.0

What problem does this PR solve?

close #1099

What is changed and how it works?

FetchDDLTableNames now return all found tableNames, and some variables in trackDDL now become int represent how many tableName should used.

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@ti-srebot ti-srebot mentioned this pull request Sep 27, 2020
Merged
@ti-srebot ti-srebot added needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated priority/normal Minor change, requires approval from ≥1 primary reviewer type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport) labels Sep 27, 2020
@GMHDBJD
Copy link
Collaborator

GMHDBJD commented Sep 27, 2020

/run-all-tests

GMHDBJD
GMHDBJD reviewed Sep 27, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added the status/LGT1 One reviewer already commented LGTM label Sep 27, 2020
@GMHDBJD
Copy link
Collaborator

GMHDBJD commented Sep 28, 2020

/run-all-tests

csuzhangxc
csuzhangxc approved these changes Sep 28, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc merged commit 0cecb73 into pingcap:release-2.0 Sep 28, 2020
@csuzhangxc csuzhangxc added already-update-release-note The release note is updated. Add this label once the release note is updated and removed needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Oct 27, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 milestone Oct 27, 2020
@lance6716 lance6716 removed the needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated label Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GMHDBJD GMHDBJD GMHDBJD left review comments

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees
No one assigned
Labels
already-update-release-note The release note is updated. Add this label once the release note is updated priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT1 One reviewer already commented LGTM type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-srebot @GMHDBJD @csuzhangxc @lance6716