Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

OperateSchema: init workerReq with source (#1104) #1106

Merged
merged 1 commit into from
Sep 25, 2020
Merged

OperateSchema: init workerReq with source (#1104) #1106

merged 1 commit into from
Sep 25, 2020

Conversation

ti-srebot
Copy link

cherry-pick #1104 to release-2.0

What problem does this PR solve?

close #1102

What is changed and how it works?

fix workerReq.Source change concurrently.

Check List

Tests

  • Integration test

@ti-srebot ti-srebot mentioned this pull request Sep 25, 2020
Merged
@ti-srebot ti-srebot added needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated priority/normal Minor change, requires approval from ≥1 primary reviewer type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport) labels Sep 25, 2020
@lance6716
Copy link
Collaborator

LGTM

@ti-srebot ti-srebot added the status/LGT1 One reviewer already commented LGTM label Sep 25, 2020
csuzhangxc
csuzhangxc approved these changes Sep 25, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Sep 25, 2020
@csuzhangxc
Copy link
Member

/run-all-tests

fail case recorded

@lance6716 lance6716 merged commit 6824293 into pingcap:release-2.0 Sep 25, 2020
@csuzhangxc csuzhangxc added already-update-release-note The release note is updated. Add this label once the release note is updated and removed needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc approved these changes

@lance6716 lance6716 Awaiting requested review from lance6716

Assignees
No one assigned
Labels
already-update-release-note The release note is updated. Add this label once the release note is updated priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-srebot @lance6716 @csuzhangxc @GMHDBJD