Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

tracker: don't execute add FK on tracker #1093

Merged
merged 2 commits into from
Sep 25, 2020
Merged

tracker: don't execute add FK on tracker #1093

merged 2 commits into from
Sep 25, 2020

Conversation

lance6716
Copy link
Collaborator

@lance6716 lance6716 commented Sep 24, 2020 •
edited
Loading

What problem does this PR solve?

close #1056

What is changed and how it works?

if a DDL is "alter atble add FK", don't execute it on tracker

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

@lance6716 lance6716 changed the title tracker: don't execute add FK in case tracker doesn't have referenced… tracker: don't execute add FK on tracker Sep 24, 2020
@lance6716 lance6716 added priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix labels Sep 24, 2020
@lance6716
Copy link
Collaborator Author

/run-all-tests

failed test recorded in #1046

@lance6716 lance6716 added the needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 label Sep 24, 2020
@lance6716
Copy link
Collaborator Author

/run-all-tests

1 similar comment
@lance6716
Copy link
Collaborator Author

/run-all-tests

@lance6716 lance6716 added status/WIP This PR is still work in progress status/PTAL This PR is ready for review. Add this label back after committing new changes and removed status/PTAL This PR is ready for review. Add this label back after committing new changes status/WIP This PR is still work in progress labels Sep 25, 2020
csuzhangxc
csuzhangxc reviewed Sep 25, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Sep 25, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC.3 milestone Sep 25, 2020
@lance6716
Copy link
Collaborator Author

PTAL @GMHDBJD . I'm going to fix #1099 based on this part, in order to reduce confilct

GMHDBJD
GMHDBJD approved these changes Sep 25, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Sep 25, 2020
@lance6716 lance6716 merged commit 63b38ba into pingcap:master Sep 25, 2020
@lance6716 lance6716 deleted the ignore-alter-fk branch September 25, 2020 06:05
@ti-srebot ti-srebot mentioned this pull request Sep 25, 2020
Merged
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #1101

@ti-srebot ti-srebot added the already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked label Sep 25, 2020
@ti-srebot ti-srebot removed the needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 label Sep 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/bug-fix Bug fix
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

reference table not exists when add foreign key statement is the first statement that table in syncer
4 participants
@lance6716 @ti-srebot @csuzhangxc @GMHDBJD