Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

task_checker: ignore more unrecoverable error #1077

Merged
merged 4 commits into from
Sep 23, 2020

Conversation

lance6716
Copy link
Collaborator

What problem does this PR solve?

ignore more unrecoverable error from https://docs.pingcap.com/zh/tidb/stable/tidb-limitations. some errors are not generated in MySQL and TiDB (partition number limit) so omitted.

What is changed and how it works?

add more error message

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    get these message from latest TiDB

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

@lance6716 lance6716 added needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 priority/unimportant Really minor change, requires approval from secondary reviewers status/PTAL This PR is ready for review. Add this label back after committing new changes labels Sep 23, 2020
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Sep 23, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC.3 milestone Sep 23, 2020
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Sep 23, 2020
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #1085

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Sep 23, 2020
@lance6716 lance6716 deleted the ignore-auto-resume branch September 23, 2020 08:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked priority/unimportant Really minor change, requires approval from secondary reviewers status/LGT2 Two reviewers already commented LGTM, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants