Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

syncer: remove KEY index in DML concurrency keys #1061

Merged
merged 1 commit into from
Sep 18, 2020
Merged

syncer: remove KEY index in DML concurrency keys #1061

merged 1 commit into from
Sep 18, 2020

Conversation

lance6716
Copy link
Collaborator

What problem does this PR solve?

KEY index will be added in DML concurrency keys, which will slow the sync.

What is changed and how it works?

remove it

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

@lance6716 lance6716 added needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes labels Sep 18, 2020
@lance6716
Copy link
Collaborator Author

/run-all-tests

@lance6716 lance6716 added the type/bug-fix Bug fix label Sep 18, 2020
zier-one
zier-one reviewed Sep 18, 2020
View reviewed changes
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lance6716 lance6716 added the status/LGT1 One reviewer already commented LGTM label Sep 18, 2020
3pointer
3pointer reviewed Sep 18, 2020
View reviewed changes
Copy link
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

3pointer
3pointer approved these changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lance6716 lance6716 merged commit 60d4bfb into pingcap:master Sep 18, 2020
@ti-srebot ti-srebot mentioned this pull request Sep 18, 2020
Merged
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #1063

@ti-srebot ti-srebot added the already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked label Sep 18, 2020
@lance6716 lance6716 deleted the hotfix-2030 branch September 18, 2020 09:32
@ti-srebot ti-srebot removed the needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 label Sep 18, 2020
lance6716 added a commit to lance6716/dm that referenced this pull request Sep 18, 2020
@lance6716
syncer: remove KEY index in DML concurrency keys (pingcap#1061)
433572d
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zier-one zier-one zier-one left review comments

@3pointer 3pointer 3pointer approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT1 One reviewer already commented LGTM status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lance6716 @ti-srebot @3pointer @zier-one