Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

ddl: pause subtask when exec ddl err (#1055) #1059

Merged
merged 3 commits into from
Sep 18, 2020
Merged

ddl: pause subtask when exec ddl err (#1055) #1059

merged 3 commits into from
Sep 18, 2020

Conversation

ti-srebot
Copy link

cherry-pick #1055 to release-2.0

What problem does this PR solve?

close #984

What is changed and how it works?

  • report error when execute ddl fail in dowsteam TiDB
  • omit error in syncDDL caller to avoid duplicate error message

Check List

Tests

  • Integration test

@ti-srebot ti-srebot mentioned this pull request Sep 18, 2020
Merged
@ti-srebot ti-srebot added priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport) labels Sep 18, 2020
@lance6716
Copy link
Collaborator

LGTM

@ti-srebot ti-srebot added the status/LGT1 One reviewer already commented LGTM label Sep 18, 2020
@csuzhangxc csuzhangxc merged commit 0e7f728 into pingcap:release-2.0 Sep 18, 2020
@csuzhangxc csuzhangxc added the needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated label Sep 18, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC.3 milestone Sep 18, 2020
@csuzhangxc csuzhangxc added already-update-release-note The release note is updated. Add this label once the release note is updated and removed needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated status/PTAL This PR is ready for review. Add this label back after committing new changes labels Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@csuzhangxc csuzhangxc Awaiting requested review from csuzhangxc

Assignees
No one assigned
Labels
already-update-release-note The release note is updated. Add this label once the release note is updated priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT1 One reviewer already commented LGTM type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-srebot @lance6716 @csuzhangxc @GMHDBJD