Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

tls: use tls in list-member #1045

Merged
merged 2 commits into from
Sep 16, 2020
Merged

tls: use tls in list-member #1045

merged 2 commits into from
Sep 16, 2020

Conversation

GMHDBJD
Copy link
Collaborator

@GMHDBJD GMHDBJD commented Sep 16, 2020

What problem does this PR solve?

fix master offline in list-member when use tls.

What is changed and how it works?

use tls for http client

Check List

Tests

  • Integration test

@GMHDBJD GMHDBJD added priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Sep 16, 2020
@GMHDBJD GMHDBJD requested a review from lichunzhu September 16, 2020 07:51
lichunzhu
lichunzhu approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD
Copy link
Collaborator Author

GMHDBJD commented Sep 16, 2020

/run-all-tests

@csuzhangxc
Copy link
Member

/run-all-tests

rpc addr 127.0.0.1:8261 check alive timeout

csuzhangxc
csuzhangxc approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Sep 16, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC.3 milestone Sep 16, 2020
@GMHDBJD GMHDBJD merged commit b985fe5 into pingcap:master Sep 16, 2020
@GMHDBJD GMHDBJD deleted the fixListMemberTls branch September 16, 2020 10:46
@ti-srebot ti-srebot mentioned this pull request Sep 16, 2020
Merged
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #1050

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Sep 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lichunzhu lichunzhu lichunzhu approved these changes

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/bug-fix Bug fix
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@GMHDBJD @csuzhangxc @ti-srebot @lichunzhu