fix: update saved task config when restarting DM-worker

pingcap · Jun 16, 2020 · e477779 · e477779
1 parent 8da96c8
commit e477779
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/dm/worker/worker.go b/dm/worker/worker.go
@@ -741,6 +741,9 @@ func (w *Worker) restoreSubTask() error {
 			return terror.Annotatef(err, "decode subtask config %s error in restoreSubTask", task.Task)
 		}
 
+		// when restarting DM-worker, some config items may need to be updated for the previous saved task config.
+		w.copyConfigFromWorker(taskCfg)
+
 		cfgDecrypted, err := taskCfg.DecryptPassword()
 		if err != nil {
 			return err

diff --git a/tests/sequence_sharding/conf/dm-task.yaml b/tests/sequence_sharding/conf/dm-task.yaml
@@ -4,6 +4,7 @@ task-mode: all
 is-sharding: true
 meta-schema: "dm_meta"
 remove-meta: false
+enable-heartbeat: true
 timezone: "Asia/Shanghai"
 
 target-database: