Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Cherry-pick: row data lost (#315) #323

Merged
merged 2 commits into from
May 29, 2020

Conversation

3pointer
Copy link
Collaborator

cherry-pick #315 to release-3.1

What problem does this PR solve?

Try fix row data lost.

What is changed and how it works?

row id bigger than 9151314442816847872 after encoded may exceed than default max range end 0xff, change it 10*[0xff]

Check List

Tests

  • Integration test
  • manual test

Release Note

  • Fix the row data lost when row_id bigger than 9151314442816847872

* try fix lost row data
@kennytm

This comment has been minimized.

@kennytm
Copy link
Collaborator

kennytm commented May 28, 2020

/run-integration-test

@3pointer

This comment has been minimized.

@3pointer
Copy link
Collaborator Author

/run-integration-test

1 similar comment
@3pointer
Copy link
Collaborator Author

/run-integration-test

@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #323 into release-3.1 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release-3.1     #323   +/-   ##
============================================
  Coverage        70.59%   70.59%           
============================================
  Files               48       48           
  Lines             5002     5002           
============================================
  Hits              3531     3531           
  Misses            1003     1003           
  Partials           468      468           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8170f4...7b57c33. Read the comment docs.

Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@3pointer 3pointer merged commit 5437159 into pingcap:release-3.1 May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants