This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… client.* restore: don't fail when RegionError has no leader* restore: use findLeaderErr instead of splitErrors* *: use go.uber.org/multierr instead of coreos/multierror.* restore: add failpoint tests on retry.* *: make linter happy.* *: remove probabilistic, and disable failpoint anyway.* restore: add test on generic retryable error.* *: fix CI.* restore: use failpoint to inject leader.* *: enable failpoint in testcover.* *: accept some advise from @kenny.* *: add a test point.* Update pkg/restore/split_client.goCo-authored-by: kennytm <[email protected]>* restore: apply suggestions.* Merge branch 'master' of https://github.com/pingcap/br into retry-split-master* go.mod: fix version of failpoint.* restore: remove some retry on batcher.Co-authored-by: kennytm <[email protected]>
…nto cp-retry-split-3.1
kennytm
approved these changes
May 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Meet many |
/run-integration-test |
1 similar comment
/run-integration-test |
PTAL @overvenus |
overvenus
approved these changes
May 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
cherry-pick #247 to 3.1 manually.
Release Note
NotLeader
.