This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
pass sse_kms_key_id to S3 (#243) #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Thank you for working on BR! Please read BR's [CONTRIBUTING](https://github.com/pingcap/br/blob/master/CONTRIBUTING.md) document **BEFORE** filing this PR. --> Pass sse_kms_key_id when backup to S3. This is to support using user owned KMS key for server-side encryption. Pass sse_kms_key_id when backup to S3 to both tikv and when storing backupmeta in S3. Tests <!-- At least one of them must be included. --> Manual test with BR. Try: * specify kms key id on backup. restore success. * disable the kms key and try restore again. restore failed. Related changes depends on kvproto change: pingcap/kvproto#607 and tikv change: tikv/tikv#7627 Signed-off-by: Yi Wu <[email protected]> Co-authored-by: kennytm <[email protected]>
|
Lgtm |
overvenus
approved these changes
May 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass sse_kms_key_id when backup to S3. This is to support using user owned KMS key for server-side encryption.
Pass sse_kms_key_id when backup to S3 to both tikv and when storing backupmeta in S3.
Tests
Manual test with BR. Try:
Related changes
depends on kvproto change: pingcap/kvproto#607 and tikv change: tikv/tikv#7627
Signed-off-by: Yi Wu [email protected]
Co-authored-by: kennytm [email protected]