Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

lightning: fix encode kvs size greater than 4.0g caused pebble panic (#1105) #1127

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1105

What problem does this PR solve?

panic: pebble: batch too large: >= 4.0 G

What is changed and how it works?

sends kv batch every 96k.

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Note

  • Fix the issue that lightning panic due to batch kv greater than 4.0g.

Copy link
Collaborator

@Little-Wallace Little-Wallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label May 25, 2021
@3pointer
Copy link
Collaborator

/run-integration-tests

@3pointer
Copy link
Collaborator

/rebuild

@glorv
Copy link
Collaborator

glorv commented May 26, 2021

/lgtm

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Little-Wallace
  • glorv

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels May 26, 2021
@3pointer
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: dccb242

@lonng
Copy link
Contributor

lonng commented May 26, 2021

/merge

@lonng
Copy link
Contributor

lonng commented May 26, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit 0a47650 into pingcap:release-5.0 May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants